Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
j-rivero
left a comment
j-rivero
left a comment
There was a problem hiding this comment.
If I'm not wrong, most of the code is the same than in the other action, it would be great to use a composite action for this https://docs.github.com/en/actions/creating-actions/creating-a-composite-action. I left this to your criteria.
Minor comment of the naming, code looks just fine.
| . /opt/ros/galactic/local_setup.sh | ||
| colcon test --event-handlers console_direct+ --packages-select gazebo_ros2_control gazebo_ros2_control_demos | ||
| colcon test-result | ||
| build_prerelease: |
There was a problem hiding this comment.
When looking into the CI matrix the prelease term distracted me, how about changing it to build_testing to match the change in the building context when using testing repo?
|
Another question: the github actions seems to be using galactic, but this PR is targeted to master branch (which I assume that is probably Rolling). Is this expected? |
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
galactic and rolling are the same at this point |
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
* Added prerelease CI Signed-off-by: ahcorde <ahcorde@gmail.com> * Change name of the job Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> * Migrate to component lifecycle (ros-controls#94) Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
2 participants
Signed-off-by: ahcorde ahcorde@gmail.com